Save custom attribute like wait_time in SeleniumRequest into Request.meta #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical way to share info between
Request
and download middleware isRequest.meta
.Custom attributes
Request.custom_attr
should be avoided, cause it may be droppedafter possible serialization and de-serialization in
Scheduler
.E.g.
scrapy-redis
convertsRequest
into dict withscrapy.utils.reqpar.request_to_dict()
. Custom attribute onRequest
will be lost.