Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight search results in single-category filter menus (#546) #559

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

hunterckx
Copy link
Collaborator

No description provided.

@frano-m
Copy link
Collaborator

frano-m commented Jan 11, 2024

@hunterckx great PR!

I only have a few tiny nits - and they are really, really tiny so overall and excellent job. Love the reuse of getSortMatchesFn.

  • In the HighlightedLabel and the VariableSizeListItem components the import path for FilterMenuSearchMatchRange can be shortened to "../../common/entities".
  • Similarly the import FilterMenuSearchMatch in the FilterMenu component can be shortened to "../../common/entities".
  • Update the css in MatchHighlight styles so that they are ordered alphabetically (😬).
  • I think you can simplify the rendering of HighlightedLabel in the VariableSizeListItem component(s) from:
primary={<HighlightedLabel label={label} ranges={matchRanges}></HighlightedLabel>

to:

primary={<HighlightedLabel label={label} ranges={matchRanges} />}

Nice work on the component creation HighlightedLabel and subsequent style clean up! ⭐!!

Copy link
Collaborator

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hunterckx.

@hunterckx hunterckx merged commit c604026 into main Jan 11, 2024
1 check passed
@hunterckx hunterckx deleted the hunter/546-highlight-category-filters branch January 11, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants