Remove chrome's --no-sandbox from tests
#576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tests included the `--no-sandbox` option for chrome. This seems to have been harmless until recently. On Windows, it now results in orphaned chrome processes which results in tests bogging and then, after a long, while failing. Removing `--no-sandbox` when running on Windows resolves the issue. The `--no-sandbox` option allows testing under a root user. Because we don't run tests under root on any OS or environment, I feel comfortable removing `--no-sandbox` across all OS testing. This change also includes new bb task `ps`, a bare-bones cross-platform way to report on running processes. This was useful while diagnosing the issue so I've left it in. I also switched from `babashka.process/destroy` to `babashka.process/destroy-tree` when killing a web driver process. This did not help with the Windows chrome orphan issue, but I expect it is generally a better way to go. Closes #572
|
Ok, back to the regular old flakiness. At least tests can pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests included the
--no-sandboxoption for chrome.This seems to have been harmless until recently.
On Windows, it now results in orphaned chrome processes which results in tests bogging and then, after a long, while failing.
Removing
--no-sandboxwhen running on Windows resolves the issue.The
--no-sandboxoption allows testing under a root user. Because we don't run tests under root on any OS or environment, I feel comfortable removing--no-sandboxacross all OS testing.This change also includes new bb task
ps, a bare-bones cross-platform way to report on running processes. This was useful while diagnosing the issue so I've left it in.I also switched from
babashka.process/destroytobabashka.process/destroy-treewhen killing a web driver process. This did not help with the Windows chrome orphan issue, but I expect it is generally a better way to go.Closes #572
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.