Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for equiv and equals #34

Conversation

jafingerhut
Copy link
Contributor

No description provided.

amalloy and others added 3 commits August 14, 2017 12:57
There are test cases added that fail without these changes.  (=
ordered-map some-record-with-same-keys) returns true without these
changes, for example, whereas Clojure's built-in maps are never = to
any record, by design, since records are distinct types.

(.equals ordered-map something-else) currently uses = to compare
corresponding values in the maps, but other Clojure persistent maps
use .equals to compare corresponding values.
jafingerhut added a commit to jafingerhut/thalia that referenced this pull request May 9, 2018
These tests have found small to medium issues with = and/or hash in
several Clojure collection libraries I have tested.  I have filed
issues and suggested patches to fix these issues.

data.avl 0.0.17 - https://dev.clojure.org/jira/browse/DAVL-10
data.int-map 0.2.4 - https://dev.clojure.org/jira/browse/DIMAP-16
data.priority-map 0.0.9 - https://dev.clojure.org/jira/browse/DPRIMAP-12
org.flatland/ordered 1.5.6 - clj-commons/ordered#34
@jafingerhut
Copy link
Contributor Author

Closing this PR in favor of #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants