Close zipfile before removing #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please consider the following patch to close zipfile before removing it, while unzipping.
It appears as if windows 7/10 is holding a handle to the open zip file, and as such can't remove it before is being closed.
For example, when building plotly from cljsjs/packages on windows (either 7 or 10), the following error is thrown:
.../cljsjs-packages/plotly $ boot package
...
Downloading v1.45.3.zip
...
Extracting 2873 files
java.lang.Thread.run
java.util.concurrent.ThreadPoolExecutor$Worker.run
java.util.concurrent.ThreadPoolExecutor.runWorker
java.util.concurrent.FutureTask.run
...
clojure.core/binding-conveyor-fn/fn core.clj: 1938
boot.core/boot/fn core.clj: 1031
boot.core/run-tasks core.clj: 1022
cljsjs.boot-cljsjs.packaging/eval3200/fn/G/fn packaging.clj: 106
cljsjs.boot-cljsjs.packaging/eval3088/fn/fn/fn packaging.clj: 72
boot.core/commit! core.clj: 463
boot.tmpdir.TmpFileSet/commit! tmpdir.clj: 258
boot.file/delete-file file.clj: 71
...
clojure.java.io/delete-file io.clj: 430
clojure.java.io/delete-file io.clj: 434
java.io.IOException: Couldn't delete C:\Users\chaos.boot\cache\tmp\dev\gh\cljsjs-packages\plotly\gps-qix298\v1.45.3.zip
Thanks