Track compute metrics for sql dml with new engine #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
reviewed
Jan 29, 2025
joshua-spacetime
force-pushed
the
joshua/query-billing-metrics
branch
from
e003202 to
7fe9162
Compare
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
a1cc95e to
31a3c33
Compare
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
31a3c33 to
a841cea
Compare
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
a841cea to
dc93f80
Compare
mamcx
reviewed
Jan 30, 2025
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
b3d25c9 to
1cd7196
Compare
mamcx
approved these changes
Jan 31, 2025
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
1cd7196 to
3f57d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
DML was still using the old engine. This patch updates it to use the new engine.
NOTE: Internal tests are failing due to a new dependency in core. Hence this pr will merge with internal tests failing, but they will be fixed immediately afterwards.
API and ABI breaking changes
None
Expected complexity level and risk
3
There are a few non-trivial changes:
SETandSHOWstatements are rewritten asINSERTandSELECTrespectivelyTesting
All previous tests still apply