Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the test that verify the query AST to use EXPLAIN instead #2194

Open
wants to merge 1 commit into
base: mamcx/planner-printer
Choose a base branch
from
Open

Change the test that verify the query AST to use EXPLAIN instead #2194

wants to merge 1 commit into from

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Jan 30, 2025

Description of Changes

Stacked on top of #2075.

This removes the manual matches against the AST to use the new EXPLAIN support, to simplify the tests and make them easier to understand.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • Most of the current tests pass.
  • There are manual checks still for things we don't support

In concrete, we need support for multi-column indexes, index scans for ranges

@mamcx mamcx added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Jan 30, 2025
@mamcx mamcx self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-spacetime joshua-spacetime Awaiting requested review from joshua-spacetime

Assignees

@mamcx mamcx

Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mamcx