-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Energy metering for persistent memory usage #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you please integrate this in spacetimedb_table
? I'd like to avoid mem-arch getting further away from being merged.
88a3fb9
to
81bffb6
Compare
81bffb6
to
4ce0970
Compare
@coolreader18 I just want to confirm for PR shepherding purposes - this change is backwards-compatible right? |
@bfops yes, it is. |
Oh, from the user side at least - cloud will need an update (but I have it ready already) |
4ce0970
to
6f3fadc
Compare
The hashbrown update is because 0.15 added an |
ddaeee4
to
29a65bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @coolreader18! Just a few typos, but otherwise looks good.
You've accounted for nearly all mem usage :)
I think it would have been sufficient to just track the pages, indexes, blob store, and pointer map. That probably could have reduced a lot of the boilerplate. But this is very nice nonetheless.
300be74
to
fb69349
Compare
fb69349
to
d897004
Compare
Description of Changes
As on the tin. I think this is the idea, right? Or am I missing another part of the database that stores user data in-memory.
Expected complexity level and risk
2