Update DLLs #243
Closed
Update DLLs #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I believe this PR will be failing until #242 lands now, since clockworklabs/SpacetimeDB#2243 landed. |
1 task
|
closing in favor of #236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update the DLLs after the clockworklabs/SpacetimeDB#2220 merge.
API
This just updates the DLLs for a breaking change. The code change in this repo has already merged (#239).
Requires SpacetimeDB PRs
masterTestsuite
SpacetimeDB branch name: master
Testing
Existing test suite passes now. Without updated DLLs we get CI failures for missing symbols: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/actions/runs/13231111053/job/36928394388.