set comprehension

cloud-bulldozer · Jan 9, 2025 · fb2bd9f · fb2bd9f
1 parent eaebe65
commit fb2bd9f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/backend/app/api/v1/commons/constants.py b/backend/app/api/v1/commons/constants.py
@@ -1,4 +1,5 @@
 # Define the keywords for sorting.
+# numeric values take no .keyword
 DIRECTIONS = ("asc", "desc")
 FIELDS = (
     "ciSystem.keyword",
@@ -21,7 +22,6 @@
     "infraNodesCount",
     "totalNodesCount",
 )
-
 OCP_FIELD_CONSTANT_DICT = {
     "ciSystem": "ciSystem.keyword",
     "platform": "platform.keyword",

diff --git a/backend/app/api/v1/commons/ocp.py b/backend/app/api/v1/commons/ocp.py
@@ -101,16 +101,9 @@ async def getFilterData(start_datetime: date, end_datetime: date, configpath: st
 
 def getJobType(upstreamList: list):
     return list(
-        set(
-            [
-                "periodic" if "periodic" in item else "pull-request"
-                for item in upstreamList
-            ]
-        )
+        {"periodic" if "periodic" in item else "pull-request" for item in upstreamList}
     )
 
 
 def getIsRehearse(upstreamList: list):
-    return list(
-        set(["True" if "rehearse" in item else "False" for item in upstreamList])
-    )
+    return list({"True" if "rehearse" in item else "False" for item in upstreamList})
diff --git a/backend/app/api/v1/commons/utils.py b/backend/app/api/v1/commons/utils.py
@@ -53,11 +53,7 @@ def getBuild(job):
 
 def getReleaseStream(row):
     releaseStream = next(
-        (
-            value
-            for key, value in RELEASE_STREAM_DICT.items()
-            if key in row["releaseStream"]
-        ),
+        (v for k, v in RELEASE_STREAM_DICT.items() if k in row["releaseStream"]),
         "Stable",
     )
     return releaseStream