Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Pagination ISSUE-143 #147

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Random Pagination ISSUE-143 #147

merged 5 commits into from
Jan 13, 2025

Conversation

MVarshini
Copy link
Collaborator

Random Pagination not working

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Pagination on clicking first and last buttons not working

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@MVarshini MVarshini self-assigned this Dec 16, 2024
@MVarshini MVarshini requested a review from dbutenhof December 27, 2024 12:26
jaredoconnell
jaredoconnell reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns match Dave's.

backend/app/api/v1/endpoints/cpt/cptJobs.py Outdated Show resolved Hide resolved
dbutenhof
dbutenhof approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that you're running into the same Poetry 2.0 problems that Vishnu hit. He needs to fix his fix, and you'll need to merge or copy that onto your revamp branch.

(Sigh. If only the world would stand still while we aim ... 😆 )

jaredoconnell
jaredoconnell approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to see the normalization code moved to a function.

@dbutenhof dbutenhof merged commit 5e66268 into cloud-bulldozer:revamp Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@vishnuchalla vishnuchalla Awaiting requested review from vishnuchalla

Assignees

@MVarshini MVarshini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MVarshini @jaredoconnell @dbutenhof