Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot memory data point #148

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abraham2512
Copy link

@abraham2512 abraham2512 commented Dec 18, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This change is intended to include memory usage data from splunk in the cpu_util graph plot

Related Tickets & Documents

Jira issue key:

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@abraham2512 abraham2512 changed the title plot memory data point Plot memory data point Jan 14, 2025
@vishnuchalla vishnuchalla self-requested a review January 14, 2025 15:24
@vishnuchalla
Copy link
Collaborator

@abraham2512 can you rebase this?

@abraham2512
Copy link
Author

@vishnuchalla thanks vishnu! Resolved conflicts and pushed.

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abraham2512 This change is mixing up both CPU and memory metrics in the UI. Would you mind taking memory usage to a separate panel and also defining a threshold to it?

Screenshot From 2025-01-28 11-08-54

@dbutenhof
Copy link
Collaborator

@abraham2512 This change is mixing up both CPU and memory metrics in the UI. Would you mind taking memory usage to a separate panel and also defining a threshold to it?

Thanks ... I had the same reaction initially, and I thought I'd commented ... but apparently I decided to wait to see what you or Vicente said, since you've got vastly greater "cultural experience" with the dashboard. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants