Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Filters for Telco #150

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Build Filters for Telco #150

merged 9 commits into from
Jan 20, 2025

Conversation

MVarshini
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Build Filters for Telco Tab

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@MVarshini MVarshini self-assigned this Dec 27, 2024
dbutenhof
dbutenhof reviewed Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments & questions ...

backend/app/services/search.py Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
frontend/src/actions/quayActions.js Outdated Show resolved Hide resolved
jaredoconnell
jaredoconnell reviewed Jan 3, 2025
View reviewed changes
backend/app/api/v1/commons/telco.py Outdated Show resolved Hide resolved
backend/app/api/v1/commons/utils.py Outdated Show resolved Hide resolved
backend/app/services/search.py Outdated Show resolved Hide resolved
dbutenhof
dbutenhof reviewed Jan 3, 2025
View reviewed changes
backend/app/api/v1/endpoints/ocp/ocpJobs.py Outdated Show resolved Hide resolved
backend/app/services/splunk.py Outdated Show resolved Hide resolved
backend/app/services/splunk.py Outdated Show resolved Hide resolved
backend/app/services/splunk.py Outdated Show resolved Hide resolved
frontend/src/actions/ocpActions.js Outdated Show resolved Hide resolved
jaredoconnell
jaredoconnell reviewed Jan 3, 2025
View reviewed changes
backend/app/api/v1/endpoints/quay/quayJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py Outdated Show resolved Hide resolved
frontend/src/actions/ocpActions.js Outdated Show resolved Hide resolved
@MVarshini MVarshini mentioned this pull request Jan 7, 2025
Merged
7 tasks
dbutenhof
dbutenhof reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've inherited the same poetry 2.0 problems from the updated stream9 base image, so we'll need a merge and cleanup before it can finish. I also found some minor new comments; but this is looking good.

backend/app/api/v1/commons/utils.py Outdated Show resolved Hide resolved
backend/app/api/v1/commons/utils.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/ocp/ocpJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/ocp/ocpJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/quay/quayJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/quay/quayJobs.py Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py Show resolved Hide resolved
frontend/src/actions/telcoActions.js Outdated Show resolved Hide resolved
frontend/src/actions/ocpActions.js Outdated Show resolved Hide resolved
jaredoconnell
jaredoconnell approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready once me and Dave's comments are addressed.

backend/app/api/v1/endpoints/quay/quayJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/quay/quayJobs.py Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py Show resolved Hide resolved
dbutenhof
dbutenhof reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few aspects could be incrementally improved (including consistency in the ":" vs "." issue); but at this point I'm going to say "this passes the threshold". On the other hand, I don't think "approval" is meaningful since we really need to have Vishnu's poetry fix merged up to revamp.

backend/app/api/v1/commons/utils.py Outdated Show resolved Hide resolved
frontend/src/actions/ocpActions.js Outdated Show resolved Hide resolved
backend/app/api/v1/endpoints/telco/telcoJobs.py
"/api/v1/telco/filters",
summary="Returns data to build the filter",
description="Returns a list of jobs in the specified dates of requested size. \
If not dates are provided the API will use the following values as defaults. \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You took Jared's suggestion of using "the following values as defaults:" with the ":" rather than "." in at least one instance, but not consistently. I'd prefer consistency.

dbutenhof
dbutenhof approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still Jared's ":" vs "." comment; but that's minor, so I'll approve and let you decide whether to complete that change.

@dbutenhof dbutenhof merged commit 6f0dfc9 into cloud-bulldozer:revamp Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@chentex chentex Awaiting requested review from chentex

@vishnuchalla vishnuchalla Awaiting requested review from vishnuchalla

Assignees

@MVarshini MVarshini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MVarshini @jaredoconnell @dbutenhof