-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix in ROSA HCP filter #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about the intended ROSA filter behavior to "approve" or object, but minor comments ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the CI? It'd be nice not to have this go onto main
with the broken checks. (We don't have much of a CI, so let's at least keep what we've got passing.)
Then Varshini can merge main
into her branch before we talk about how to bring revamp
back onto main
. (And following that, my whole chain of Crucible/ILAB changes which includes at least a start on real unit testing ... and some formatting and lint checks.)
536da2b
to
9048034
Compare
Signed-off-by: Vishnu Challa <[email protected]>
Sure. Poetry is fixed. Had to rewrite based on Poetry 2.0 latest syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@vishnuchalla ... you have two approvals. You tagged @jtaleric for review -- do you want to wait, or should we just get this in? I want @MVarshini to be able to merge this into |
Lets wait for a day for @jtaleric 's review. Since this is a small change, I think we are good to go for a merge. |
Type of change
Description
While looking at the some of the worker-scale workload results, noticed that rosa HCP runs are not being filtered properly. So, adding a fix for that.
Checklist before requesting a review
Testing
Tested using
local-compose.sh
Before this change
After this change