Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in ROSA HCP filter #151

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jan 7, 2025

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

While looking at the some of the worker-scale workload results, noticed that rosa HCP runs are not being filtered properly. So, adding a fix for that.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested using local-compose.sh

Before this change

Screenshot From 2025-01-06 21-09-26

After this change

Screenshot From 2025-01-06 21-01-59

Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about the intended ROSA filter behavior to "approve" or object, but minor comments ...

backend/app/api/v1/commons/utils.py Outdated Show resolved Hide resolved
backend/backend.containerfile Show resolved Hide resolved
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CI? It'd be nice not to have this go onto main with the broken checks. (We don't have much of a CI, so let's at least keep what we've got passing.)

Then Varshini can merge main into her branch before we talk about how to bring revamp back onto main. (And following that, my whole chain of Crucible/ILAB changes which includes at least a start on real unit testing ... and some formatting and lint checks.)

backend/app/api/v1/commons/utils.py Show resolved Hide resolved
@vishnuchalla vishnuchalla force-pushed the rosa-hcp branch 2 times, most recently from 536da2b to 9048034 Compare January 8, 2025 16:28
Signed-off-by: Vishnu Challa <[email protected]>
@vishnuchalla
Copy link
Collaborator Author

Can you fix the CI? It'd be nice not to have this go onto main with the broken checks. (We don't have much of a CI, so let's at least keep what we've got passing.)

Then Varshini can merge main into her branch before we talk about how to bring revamp back onto main. (And following that, my whole chain of Crucible/ILAB changes which includes at least a start on real unit testing ... and some formatting and lint checks.)

Sure. Poetry is fixed. Had to rewrite based on Poetry 2.0 latest syntax.

Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dbutenhof
Copy link
Collaborator

@vishnuchalla ... you have two approvals. You tagged @jtaleric for review -- do you want to wait, or should we just get this in? I want @MVarshini to be able to merge this into revamp so we can get her remaining refactoring merged and move ahead...

@vishnuchalla
Copy link
Collaborator Author

@vishnuchalla ... you have two approvals. You tagged @jtaleric for review -- do you want to wait, or should we just get this in? I want @MVarshini to be able to merge this into revamp so we can get her remaining refactoring merged and move ahead...

Lets wait for a day for @jtaleric 's review. Since this is a small change, I think we are good to go for a merge.

@dbutenhof dbutenhof merged commit 284c302 into cloud-bulldozer:main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants