Dashboard Revamp #91

MVarshini · 2024-04-10T09:49:42Z

Type of change

Description

This PR revamps the current Dashboard

Updated the Layout
Added Table component with Sorting, Pagination
Integrated with CPT_JOBS API
Updated the Doc file Readme.md

Related Tickets & Documents

Related Issue # PANDA-361
Closes #

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

vishnuchalla · 2024-04-11T01:19:03Z

@MVarshini Can you please update the local-compose.sh file so that we can verify these changes? Looks like the existing one is not compatible.

frontend/src/utils/apiConstants.js

frontend/src/actions/homeActions.js

MVarshini · 2024-04-15T10:08:05Z

@MVarshini Can you please update the local-compose.sh file so that we can verify these changes? Looks like the existing one is not compatible.

@vishnuchalla Updated the file.

vishnuchalla · 2024-04-17T12:33:03Z

@MVarshini Can you please update the local-compose.sh file so that we can verify these changes? Looks like the existing one is not compatible.

@vishnuchalla Updated the file.

I still come across this error when I run sh local-compose.sh

[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.0.0 || >=20.0.0". Got "16.20.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: building at STEP "RUN yarn install": while running runtime: exit status 1
87f2197c97e62613568d0ee74158e85d4318c95da5152a2275b5244e79e1b474
Trying to pull localhost/frontend:latest...
WARN[0000] Failed, retrying in 1s ... (1/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
WARN[0001] Failed, retrying in 1s ... (2/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
WARN[0002] Failed, retrying in 1s ... (3/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused

vishnuchalla · 2024-04-29T17:54:18Z

@MVarshini Can you please update the local-compose.sh file so that we can verify these changes? Looks like the existing one is not compatible.

@vishnuchalla Updated the file.

I still come across this error when I run sh local-compose.sh

[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.0.0 || >=20.0.0". Got "16.20.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: building at STEP "RUN yarn install": while running runtime: exit status 1
87f2197c97e62613568d0ee74158e85d4318c95da5152a2275b5244e79e1b474
Trying to pull localhost/frontend:latest...
WARN[0000] Failed, retrying in 1s ... (1/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
WARN[0001] Failed, retrying in 1s ... (2/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
WARN[0002] Failed, retrying in 1s ... (3/3). Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused 
Error: initializing source docker://localhost/frontend:latest: pinging container registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused

Checked again. Works fine.

github-actions · 2024-05-29T18:38:04Z

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions · 2024-06-03T18:40:20Z

This PR was closed because it has been stalled for 6 days with no activity.

jtaleric · 2024-06-11T18:27:37Z

What is our status on this integration?

vishnuchalla · 2024-06-11T18:47:37Z

@chentex and I had to chat to get these in after the telco changes. @MVarshini would you mind updating this PR please?

Revamp CPT dashboard

jtaleric

@MVarshini I am unable to test this change, local-compose seems to run, however the frontend pod doesn't seem to be serving out anything?


> [email protected] dev
> vite


  VITE v5.2.7  ready in 156 ms

  ➜  Local:   http://localhost:3000/
  ➜  Network: use --host to expose

Is the containerfile for the frontend up to date?

MVarshini · 2024-06-13T13:18:02Z

@MVarshini I am unable to test this change, local-compose seems to run, however the frontend pod doesn't seem to be serving out anything?
> [email protected] dev
> vite


  VITE v5.2.7  ready in 156 ms

  ➜  Local:   http://localhost:3000/
  ➜  Network: use --host to expose
Is the containerfile for the frontend up to date?

@jtaleric The container file is up to date. Try to hit http://localhost:3000/ on the browser if it doesn't work let's it offline and check.

jtaleric · 2024-06-13T16:43:09Z

@MVarshini Thanks for the fix to the local-compose -- in the past we never needed hostNetwork.

There are still aspects of the new dashboard that seem broken for me.

When I select OCP, the list of tests are not updating to just OCP workloads.

When I click the menu button, I see a "hello" message.

I don't want to rush things, but is this PR ready?

MVarshini · 2024-06-13T17:22:57Z

@MVarshini Thanks for the fix to the local-compose -- in the past we never needed hostNetwork.

There are still aspects of the new dashboard that seem broken for me. When I select OCP, the list of tests are not updating to just OCP workloads.

When I click the menu button, I see a "hello" message.

I don't want to rush things, but is this PR ready?

It has only the Home Page Table and OCP page hasn't been included here.

Also, Side menu toggle is a bug and it has been fixed in this PR #102 which has both Home and OCP pages with Filter and Summary Tab

vishnuchalla · 2024-06-14T19:14:49Z

frontend/src/components/organisms/Header/index.jsx

+  const dispatch = useDispatch();
+  const onSidebarToggle = () => {
+    dispatch(toggleSideMenu(false));
+    dispatch(showToast("success", "Hello"));


nit: Please remove this message.

Addressed in PR #102

vishnuchalla

Considering as this revamp has to go in multiple PRs, I am okay with merging this PR into separate branch as an initial step and having rest of the parts integrated in the upcoming ones. For example this PR only has home page and the layout set but doesn't actually filter out stuff and show product specific data (.i.e OCP, Quay etc) which is fine. Hopefully all these items will get addressed in #102.
cc: @chentex

chentex

Thank you @MVarshini, merging this one to the revamp branch and test the #102

MVarshini requested a review from chentex April 10, 2024 09:49

MVarshini self-assigned this Apr 10, 2024

vishnuchalla reviewed Apr 11, 2024

View reviewed changes

frontend/src/utils/apiConstants.js Show resolved Hide resolved

vishnuchalla reviewed Apr 11, 2024

View reviewed changes

frontend/src/actions/homeActions.js Show resolved Hide resolved

MVarshini mentioned this pull request Apr 26, 2024

CPT Table Filters #92

Closed

7 tasks

vishnuchalla self-requested a review April 29, 2024 17:57

github-actions bot added the Stale label May 29, 2024

github-actions bot closed this Jun 3, 2024

vishnuchalla reopened this Jun 3, 2024

github-actions bot removed the Stale label Jun 4, 2024

MVarshini added 8 commits June 12, 2024 18:18

PANDA-361

4dc591c

Revamp CPT dashboard

Layout and Store

7797feb

OCP Table Laout

87552b1

sort

f3952ee

Pagination

6cb308e

Readme file update

845ca6b

Dockerfile update

62a325c

Resolved conflicts

8be3cde

MVarshini force-pushed the PANDA-361 branch from c6004dd to 8be3cde Compare June 12, 2024 13:14

jtaleric requested changes Jun 12, 2024

View reviewed changes

chentex changed the base branch from main to revamp June 13, 2024 12:32

host mapping

ae7ca38

vishnuchalla reviewed Jun 14, 2024

View reviewed changes

vishnuchalla approved these changes Jun 14, 2024

View reviewed changes

chentex approved these changes Jun 18, 2024

View reviewed changes

chentex merged commit 5ea688b into cloud-bulldozer:revamp Jun 18, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard Revamp #91

Dashboard Revamp #91

MVarshini commented Apr 10, 2024

vishnuchalla commented Apr 11, 2024 •

edited

Loading

MVarshini commented Apr 15, 2024

vishnuchalla commented Apr 17, 2024

vishnuchalla commented Apr 29, 2024

github-actions bot commented May 29, 2024

github-actions bot commented Jun 3, 2024

jtaleric commented Jun 11, 2024

vishnuchalla commented Jun 11, 2024

jtaleric left a comment

MVarshini commented Jun 13, 2024

jtaleric commented Jun 13, 2024

MVarshini commented Jun 13, 2024

vishnuchalla Jun 14, 2024

MVarshini Jun 18, 2024 •

edited

Loading

vishnuchalla left a comment

chentex left a comment

Dashboard Revamp #91

Dashboard Revamp #91

Conversation

MVarshini commented Apr 10, 2024

Type of change

Description

Related Tickets & Documents

Checklist before requesting a review

Testing

vishnuchalla commented Apr 11, 2024 • edited Loading

MVarshini commented Apr 15, 2024

vishnuchalla commented Apr 17, 2024

vishnuchalla commented Apr 29, 2024

github-actions bot commented May 29, 2024

github-actions bot commented Jun 3, 2024

jtaleric commented Jun 11, 2024

vishnuchalla commented Jun 11, 2024

jtaleric left a comment

Choose a reason for hiding this comment

MVarshini commented Jun 13, 2024

jtaleric commented Jun 13, 2024

MVarshini commented Jun 13, 2024

vishnuchalla Jun 14, 2024

Choose a reason for hiding this comment

MVarshini Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

vishnuchalla left a comment

Choose a reason for hiding this comment

chentex left a comment

Choose a reason for hiding this comment

vishnuchalla commented Apr 11, 2024 •

edited

Loading

MVarshini Jun 18, 2024 •

edited

Loading