Additional workloads: cyclictest, oslat and testpmd add #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
reviewed
Oct 16, 2021
mukrishn
reviewed
Oct 26, 2021
mukrishn
reviewed
Oct 29, 2021
jtaleric
reviewed
Nov 3, 2021
jtaleric
reviewed
Nov 3, 2021
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
| bold=$(tput bold) | ||
| uline=$(tput smul) | ||
| normal=$(tput sgr0) | ||
| python3 -m pip install -r requirements.txt | grep -v 'already satisfied' |
There was a problem hiding this comment.
We should probably deploy a venv first and then install/run from there to avoid any potential issues
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
| bold=$(tput bold) | ||
| uline=$(tput smul) | ||
| normal=$(tput sgr0) | ||
| python3 -m pip install -r requirements.txt | grep -v 'already satisfied' |
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 11, 2022
dry923
reviewed
Jan 18, 2022
| @@ -14,6 +14,21 @@ fi | |||
| export TOLERATIONS="[{key: role, value: workload, effect: NoSchedule}]" | |||
| export UUID=${UUID:-$(uuidgen)} | |||
|
|
|||
| export baremetalCheck=$(oc get infrastructure cluster -o json | jq .spec.platformSpec.type) | |||
There was a problem hiding this comment.
@rsevilla87 can you vet these changes given they impact all kube-burner e2e tests
There was a problem hiding this comment.
lgtm, seems like it checks if the test runs in a BM environment to install python 3.8 later. However I think it should be a software requirement and we shouldn't do it on runtime (we could say that oc and kubectl are also requirements.)
…from clashing / overlapping benchmarks
dry923
reviewed
Jan 20, 2022
|
@mohit-sheth @sjug @rsevilla87 Can we get another set or two of eyes on this one please? |
mukrishn
approved these changes
Jan 26, 2022
mohit-sheth
approved these changes
Jan 26, 2022
rsevilla87
reviewed
Jan 27, 2022
vishnuchalla
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Updated workloads to run on baremetal * Added oslat, cyclictest and testpmd workloads * combination of 39 commits, squashed * no more echoing empty lines * changes for the PR / removing unnecessary files * checking for the existance of id_rsa for the kni user * reverting changes * Missing bracket * changes to check only the benchmark with the current UUID to prevent from clashing / overlapping benchmarks * Turned the time to wait for the perfprofile into a variable, fixed a typo * removing the UUID part of the benchmark name in the templates * fixing a few minor issues, reverting UUID changes * fixed cyclictest index * last bits for the merge * removed a double entry * final cleanup * indentation error Co-authored-by: jdowni000 <[email protected]> Co-authored-by: Marko Karg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three more workloads added:
Fixes
n/a
This PR depends on the work @jdowni000 has done for the baremetal clusters #248