Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-commons version #121

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Bump go-commons version #121

merged 2 commits into from
Dec 1, 2023

Conversation

rsevilla87
Copy link
Member

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Recent versions of go-commons collect interesting metadata such as:

  • clusterType
  • ocpMajorVersion (We can replace ocpShortVersion by this one)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@rsevilla87
Bump go-commons version
41177ab 
Signed-off-by: Raul Sevilla <[email protected]>
@rsevilla87 rsevilla87 requested a review from jtaleric November 30, 2023 11:08
@rsevilla87
Remove deprecated fields
b17b645 
Signed-off-by: Raul Sevilla <[email protected]>
jtaleric
jtaleric approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested locally.

@jtaleric jtaleric merged commit e5300db into cloud-bulldozer:main Dec 1, 2023
5 checks passed
@rsevilla87 rsevilla87 deleted the bump-go-commons branch December 1, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsevilla87 @jtaleric