Slidingpane jordan #101
Closed
Slidingpane jordan #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same as create form Signed-off-by: Jordan Conklin <[email protected]>
Signed-off-by: Jordan Conklin <[email protected]>
Signed-off-by: Jordan Conklin <[email protected]>
NoeSamaille
requested changes
Sep 2, 2022
|
Closing as breaking changes prevent from merging cleanly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sliding pane not yet functional, search for TODO in my code before this is merged.
The Cancel/Add buttons at the bottom of the form aren't working, inspect element and see errors when you try to submit the form.
The isImport state isn't being set in the code, so the Create and Import forms are the same when they shouldn't be.
One smaller thing i noticed but couldn't get to the bottom of: as I type my responses on the form, the tiles in the background reload each time I type a letter. This doesn't happen on the .dev site with the Modal so I'm assuming it's something about my sliding pane form that isn't right––just think that is something to note.
Closes #69