Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ updates:
reviewers:
- "approvers"
# Allow up to 3 open pull requests for pip dependencies
open-pull-requests-limit: 3
open-pull-requests-limit: 3
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ jobs:
uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@master
secrets: inherit
with:
branch: 'master'
branch: 'master'
2 changes: 1 addition & 1 deletion .github/workflows/readme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # required
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }} # required
if: always()
if: always()
2 changes: 1 addition & 1 deletion .github/workflows/static-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ jobs:
terraform_version: ${{ needs.versionExtract.outputs.maxVersion }}

- name: Check Terraform format changes
run: terraform fmt --recursive -check=true
run: terraform fmt --recursive -check=true
2 changes: 1 addition & 1 deletion .github/workflows/tfsec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ jobs:
uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@master
secrets: inherit
with:
working_directory: '.'
working_directory: '.'
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,4 @@ terraform.tfstate
*.tfstate
*.tfstate.backup
*.iml
*.terraform.lock.hcl
*.terraform.lock.hcl
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
repos:

- repo: https://github.com/gruntwork-io/pre-commit
rev: v0.1.12 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
rev: v0.1.23 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
hooks:
- id: terraform-fmt
- id: shellcheck
- id: tflint

- repo: git://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1 # Use the ref you want to point at
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0 # Use the ref you want to point at
hooks:
- id: end-of-file-fixer
- id: trailing-whitespace
Expand Down
2 changes: 1 addition & 1 deletion .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
"@semantic-release/release-notes-generator",
"@semantic-release/github"
]
}
}
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0


[1.0.1]: https://github.com/clouddrove/terraform-azure-firewall/compare/1.0.0...1.0.1
[1.0.2]: https://github.com/clouddrove/terraform-azure-firewall/compare/1.0.1...1.0.2
[1.0.2]: https://github.com/clouddrove/terraform-azure-firewall/compare/1.0.1...1.0.2
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export GENIE_PATH ?= $(shell 'pwd')/../../../genie
include $(GENIE_PATH)/Makefile
include $(GENIE_PATH)/Makefile
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Terraform AZURE FIREWALL
</h1>

<p align="center" style="font-size: 1.2rem;">
<p align="center" style="font-size: 1.2rem;">
Terraform module to create firewall resource on AZURE.
</p>

Expand Down Expand Up @@ -38,7 +38,7 @@
<hr>


We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.

This module is basically combination of [Terraform open source](https://www.terraform.io/) and includes automatation tests and examples. It also helps to create and improve your infrastructure with minimalistic code instead of maintaining the whole infrastructure code yourself.

Expand All @@ -49,7 +49,7 @@ We have [*fifty plus terraform modules*][terraform_modules]. A few of them are c

## Prerequisites

This module has a few dependencies:
This module has a few dependencies:



Expand Down Expand Up @@ -420,7 +420,7 @@ module "firewall-rules" {


## Testing
In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system.
In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system.

You need to run the following command in the testing folder:
```hcl
Expand All @@ -429,7 +429,7 @@ You need to run the following command in the testing folder:



## Feedback
## Feedback
If you come accross a bug or have any feedback, please log it in our [issue tracker](https://github.com/clouddrove/terraform-azure-firewall/issues), or feel free to drop us an email at [[email protected]](mailto:[email protected]).

If you have found it worth your time, go ahead and give us a ★ on [our GitHub](https://github.com/clouddrove/terraform-azure-firewall)!
Expand Down
4 changes: 2 additions & 2 deletions _example/basic/example.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
##-----------------------------------------------------------------------------
## Firewall module call.
##-----------------------------------------------------------------------------
## Firewall module call.
## All firewall related resources will be deployed from this module, i.e. including firewall and firewall rules.
##-----------------------------------------------------------------------------
module "firewall" {
Expand Down
20 changes: 10 additions & 10 deletions _example/complete/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ locals {
environment = "test"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Resource Group module call
## Resource group in which all resources will be deployed.
##-----------------------------------------------------------------------------
Expand All @@ -20,9 +20,9 @@ module "resource_group" {
location = "East US"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Virtual Network module call.
## Virtual Network in firewall specific subnet will be created.
## Virtual Network in firewall specific subnet will be created.
##-----------------------------------------------------------------------------
module "vnet" {
depends_on = [module.resource_group]
Expand All @@ -35,9 +35,9 @@ module "vnet" {
address_space = "10.0.0.0/16"
}

##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
module "name_specific_subnet" {
depends_on = [module.vnet]
Expand All @@ -62,9 +62,9 @@ module "name_specific_subnet" {
]
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Log Analytic Module Call.
## Log Analytic workspace for firerwall diagnostic setting.
## Log Analytic workspace for firerwall diagnostic setting.
##-----------------------------------------------------------------------------
module "log-analytics" {
source = "clouddrove/log-analytics/azure"
Expand All @@ -78,8 +78,8 @@ module "log-analytics" {
log_analytics_workspace_location = module.resource_group.resource_group_location
}

##-----------------------------------------------------------------------------
## Firewall module call.
##-----------------------------------------------------------------------------
## Firewall module call.
## All firewall related resources will be deployed from this module, i.e. including firewall and firewall rules.
##-----------------------------------------------------------------------------
module "firewall" {
Expand Down
28 changes: 14 additions & 14 deletions _example/firewall-with-isolated-rules/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ locals {
environment = "test"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Resource Group module call
## Resource group in which all resources will be deployed.
##-----------------------------------------------------------------------------
Expand All @@ -20,9 +20,9 @@ module "resource_group" {
location = "East US"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Virtual Network module call.
## Virtual Network in firewall specific subnet will be created.
## Virtual Network in firewall specific subnet will be created.
##-----------------------------------------------------------------------------
module "vnet" {
depends_on = [module.resource_group]
Expand All @@ -35,9 +35,9 @@ module "vnet" {
address_space = "10.0.0.0/16"
}

##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
module "name_specific_subnet" {
depends_on = [module.vnet]
Expand All @@ -62,9 +62,9 @@ module "name_specific_subnet" {
]
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Log Analytic Module Call.
## Log Analytic workspace for firerwall diagnostic setting.
## Log Analytic workspace for firerwall diagnostic setting.
##-----------------------------------------------------------------------------
module "log-analytics" {
source = "clouddrove/log-analytics/azure"
Expand All @@ -79,9 +79,9 @@ module "log-analytics" {
}


##-----------------------------------------------------------------------------
## Firewall module call.
## From this module call firewall rules will not be deployed and thus no rule collection group will be created.
##-----------------------------------------------------------------------------
## Firewall module call.
## From this module call firewall rules will not be deployed and thus no rule collection group will be created.
##-----------------------------------------------------------------------------
module "firewall" {
depends_on = [module.name_specific_subnet]
Expand All @@ -102,9 +102,9 @@ module "firewall" {

}

##-----------------------------------------------------------------------------
## Firewall-Rules module call.
## This is same module as 'firewall module', but from this module only firewall rules and rule collection group will be deployed.
##-----------------------------------------------------------------------------
## Firewall-Rules module call.
## This is same module as 'firewall module', but from this module only firewall rules and rule collection group will be deployed.
##-----------------------------------------------------------------------------
module "firewall-rules" {
depends_on = [module.firewall]
Expand Down
20 changes: 10 additions & 10 deletions _example/firewall-with-public-ip-prefix/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ locals {
environment = "test"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Resource Group module call
## Resource group in which all resources will be deployed.
##-----------------------------------------------------------------------------
Expand All @@ -20,9 +20,9 @@ module "resource_group" {
location = "East US"
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Virtual Network module call.
## Virtual Network in firewall specific subnet will be created.
## Virtual Network in firewall specific subnet will be created.
##-----------------------------------------------------------------------------
module "vnet" {
depends_on = [module.resource_group]
Expand All @@ -35,9 +35,9 @@ module "vnet" {
address_space = "10.0.0.0/16"
}

##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
## Subnet module call.
## Name specific subnet for firewall will be created.
##-----------------------------------------------------------------------------
module "name_specific_subnet" {
depends_on = [module.vnet]
Expand All @@ -62,9 +62,9 @@ module "name_specific_subnet" {
]
}

##-----------------------------------------------------------------------------
##-----------------------------------------------------------------------------
## Log Analytic Module Call.
## Log Analytic workspace for firerwall diagnostic setting.
## Log Analytic workspace for firerwall diagnostic setting.
##-----------------------------------------------------------------------------
module "log-analytics" {
source = "clouddrove/log-analytics/azure"
Expand All @@ -78,8 +78,8 @@ module "log-analytics" {
log_analytics_workspace_location = module.resource_group.resource_group_location
}

##-----------------------------------------------------------------------------
## Firewall module call.
##-----------------------------------------------------------------------------
## Firewall module call.
## All firewall related resources will be deployed from this module, i.e. including firewall and firewall rules.
##-----------------------------------------------------------------------------
module "firewall" {
Expand Down
2 changes: 1 addition & 1 deletion _test/azure_firewall_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ func Test(t *testing.T) {
assert.Equal(t, "test-clouddrove-firewall", Tags["Name"])
assert.Contains(t, Id, "/subscriptions")
}
}
}
Loading
Loading