Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-storagebrowser] adds pagination in file preview page #3949

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • When the file is big, the preview need to be paginated.

How was this patch tested?

  • Manually tested

@ramprasadagarwal ramprasadagarwal self-assigned this Jan 10, 2025
@ramprasadagarwal ramprasadagarwal requested review from Harshg999, nidhibhatg, bjornalm and JohanAhlen and removed request for Harshg999 and nidhibhatg January 10, 2025 09:54
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@@ -209,6 +208,15 @@ def download(request):
return response


def _massage_page(page, paginator):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

1 similar comment
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 15, 2025 14:04
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@ramprasadagarwal ramprasadagarwal merged commit e67d150 into master Jan 20, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-12 branch January 20, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants