[ui-build] add strip-sourcemap-loader to remove 3rd party hardcoded m… #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
requested review from
JohanAhlen,
tabraiz12,
ramprasadagarwal and
amitsrivastava
|
|
Harshg999
approved these changes
Jan 20, 2025
JohanAhlen
approved these changes
Jan 20, 2025
bjornalm
force-pushed
the
generated-static-file-refers-to-missing-index-mjs-map
branch
from
b69bb9b to
63edd5c
Compare
|
|
bjornalm
deleted the
generated-static-file-refers-to-missing-index-mjs-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ap references
What changes were proposed in this pull request?
It seems that references to index.mjs.map (e.g.
//# sourceMappingURL=index.mjs.map) are always added to the "defaultVendors~~~~~-chunk-xxx.js" and that index.mjs.map file never exists, not even in dev mode.After a lot of digging it seems to be that case that some third party mjs-files have these map-files references hardcoded in them. This PR provides a fix that targets the mjs files under node_modules to remove these references in our bundles using a small loader called strip-sourcemap-loader.
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.