Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe inline fixes - Saml text issue and cross button fix. #3974

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

tabraiz12
Copy link
Collaborator

What changes were proposed in this pull request?

This is fixes two minor issues

  • the ui starts showing up "You're being redirected to a SSO login page." looks little odd, so hiding everything and keeping as earlier.
  • There is a cross button showing up in ui. and moving across the page

How was this patch tested?

  • Tested in mow-dev

Please review Hue Contributing Guide before opening a pull request.

@tabraiz12 tabraiz12 enabled auto-merge (squash) January 28, 2025 13:57
@tabraiz12 tabraiz12 merged commit 28c5987 into master Jan 28, 2025
5 of 6 checks passed
@tabraiz12 tabraiz12 deleted the saml-message-fix branch January 28, 2025 14:12
tabraiz12 added a commit that referenced this pull request Jan 31, 2025
#3974)

This is fixes two minor issues

the ui starts showing up "You're being redirected to a SSO login page." looks little odd, so hiding everything and keeping as earlier.
There is a cross button showing up in ui. and moving across the page
---------

Co-authored-by: Mohammed Tabraiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants