Provide some guidance on how security can be layered on top of CE #1305
+110
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Jul 18, 2024
cloudevents/primer.md
Outdated
| <dsig:DigestValue>DCDNxibEA3BHpFMtzvj7hxd7p5A=</dsig:DigestValue> | ||
| </dsig:Reference> | ||
| </dsig:SignedInfo> | ||
| <dsig:SignatureValue>jocgUrZPKR8jvery4gG4V34qx7/yxOESPJq//iS3Q5Ps7lPADNBEVK4Y50HIdrkodcYLZjBkvuGMT89nTeT24W/Dw/XEeMWXRmy/Mj1/rza8JMaP46F+2MZ6tlGWlyA2tRZNExe5TPA8Wo6jTSN3KX3aLoLkwRsLBt50Zr8zz8xFtadZciNWnsD6y/UgQzNYfLovMw54AHGk+5FzRWMgwtTseISWxSF+9zsgiQStrrXzy1SaRycQTAjz4PF6HebGWJcECLa+r/iLtigbTmgL3Mj7mkmw90M3mNncqZKBFmjNxTZCPiMQHbSvTgOBe8REwCrclHJkyYP14NsxEg6LZQ==</dsig:SignatureValue> |
There was a problem hiding this comment.
Possibly wrap this, in the same way that the base64 in the JSON is wrapped?
Fixes cloudevents#1290 Fixes cloudevents#1288 Signed-off-by: Doug Davis <[email protected]>
|
ping @AxelNennker - any thoughts? |
|
Approved on the 7/25 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1290
Fixes #1288
@AxelNennker see what you think of this PR. On a previous call we discussed your PR (#1290) and there was some concern about it making our spec look a bit too JSON specific. So, we decided to provide the same type of guidance you're looking for in the Primer along with a non-JSON example. Let us know what you think.