Special square, pow u in final exponentiation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armfazh
requested changes
Jul 16, 2023
| func (e *gfP12) SpecialSquare(a *gfP12) *gfP12 { | ||
| tmp := &gfP12{} | ||
|
|
||
| f02 := &tmp.y.x |
There was a problem hiding this comment.
Let' make clear what is the isomorphism.
gfp12.go
Outdated
| // easy part of the final exponentiation. Used in the hard part | ||
| // of the final exponentiation. Function uses formulas in | ||
| // Granger/Scott (PKC2010). | ||
| func (e *gfP12) SpecialSquare(a *gfP12) *gfP12 { |
There was a problem hiding this comment.
it can be renamed to SquareCyclotomic or something more shorter. Similarly for the exponentiation by u
There was a problem hiding this comment.
renamed to SquareCyclo6
gfp12_test.go
Outdated
| got := &gfP12{} | ||
| expected := &gfP12{} | ||
|
|
||
| got.SpecialSquare(in) |
There was a problem hiding this comment.
add some warning, since this test assume the input is in the cyclotomic subgroup.
There was a problem hiding this comment.
added requirement for input
|
Thanks for this. For ease of review, could you add more explicitly to each function what it does; what it assumes; and why it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for details, pls refer #35