Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip_access_rules: Add ListIPAccessRules api call #1428

Merged
merged 2 commits into from
Nov 17, 2023
Merged

ip_access_rules: Add ListIPAccessRules api call #1428

merged 2 commits into from
Nov 17, 2023

Conversation

dkoston
Copy link
Contributor

@dkoston dkoston commented Oct 26, 2023

Adds List IP Access Rules API Call docs

Description

Provides access to an api endpoint not provided by this library currently

Has your change been tested?

Yes, tested basic call

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [no] My change requires a change to the documentation.
  • [n/a] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@dkoston dkoston requested a review from jacobbednarz as a code owner October 26, 2023 17:55
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

changelog detected ✅

@dkoston dkoston force-pushed the dkoston/add_list_ip_access_rules branch from ddaf8f5 to 869e71c Compare October 26, 2023 18:23
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Oct 26, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
@dkoston dkoston force-pushed the dkoston/add_list_ip_access_rules branch from 869e71c to f254934 Compare October 27, 2023 14:13
dkoston
dkoston commented Oct 27, 2023
View reviewed changes
ip_access_rules.go Outdated Show resolved Hide resolved
@dkoston dkoston force-pushed the dkoston/add_list_ip_access_rules branch from f254934 to c32d5e6 Compare November 17, 2023 00:49
@dkoston
Copy link
Contributor Author

dkoston commented Nov 17, 2023

fixed the lint issue

@jacobbednarz
Copy link
Member

your fork doesn't allow maintainers to send changes so here is a patch instead. IP should be uppercase in it's usage. here is a patch for it - https://gist.github.com/jacobbednarz/57245ff4c77be94127294a761fd9d00f

@dkoston dkoston force-pushed the dkoston/add_list_ip_access_rules branch from c32d5e6 to eda96dc Compare November 17, 2023 01:45
@dkoston
Copy link
Contributor Author

dkoston commented Nov 17, 2023

Thanks @jacobbednarz! Patch applied

@jacobbednarz jacobbednarz merged commit 09b313b into cloudflare:master Nov 17, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.82.0 milestone Nov 17, 2023
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
Update CHANGELOG.md for #1428
390bde8
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v0.82.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dkoston @jacobbednarz