Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hyperdrive Config Origin model to include new fields #2729

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

mtlemilio
Copy link
Contributor

@mtlemilio mtlemilio commented Jul 9, 2024

Description

This PR updates the Hyperdrive API model to include new forthcoming fields. Some downstream changes in https://github.com/cloudflare/terraform-provider-cloudflare will depend on these changes.

Has your change been tested?

Tests have been updated to account for the new fields.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@mtlemilio mtlemilio requested a review from jacobbednarz as a code owner July 9, 2024 21:13
Copy link
Contributor

github-actions bot commented Jul 9, 2024

changelog detected ✅

Copy link

gitguardian bot commented Jul 9, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 7c65898 hyperdrive_test.go View secret
- - Generic High Entropy Secret 405f63a hyperdrive_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mtlemilio mtlemilio force-pushed the update-hyperdrive-model branch 2 times, most recently from 488af73 to 8a77381 Compare July 9, 2024 21:25
@mtlemilio mtlemilio force-pushed the update-hyperdrive-model branch from 62bbd28 to 7c65898 Compare July 9, 2024 21:40
hyperdrive.go Outdated Show resolved Hide resolved
@mtlemilio mtlemilio force-pushed the update-hyperdrive-model branch from 785ff18 to 1a62333 Compare July 11, 2024 18:19
@mtlemilio mtlemilio force-pushed the update-hyperdrive-model branch from 1a62333 to 2eabbac Compare July 11, 2024 18:23
@jacobbednarz jacobbednarz added the workflow: pending-schemas Indicates an issue or PR requires changes from an upstream library. label Jul 12, 2024
@jacobbednarz
Copy link
Member

v2 has these changes at #2742. up to you which one you want to use in Terraform since both are supported.

@jacobbednarz jacobbednarz merged commit e5e6bf4 into cloudflare:master Jul 15, 2024
9 of 10 checks passed
@github-actions github-actions bot added this to the v0.100.0 milestone Jul 15, 2024
Copy link
Contributor

This functionality has been released in v0.100.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow: pending-schemas Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants