-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hyperdrive Config Origin model to include new fields #2729
Update Hyperdrive Config Origin model to include new fields #2729
Conversation
changelog detected ✅ |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | 7c65898 | hyperdrive_test.go | View secret |
- | - | Generic High Entropy Secret | 405f63a | hyperdrive_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
488af73
to
8a77381
Compare
62bbd28
to
7c65898
Compare
785ff18
to
1a62333
Compare
1a62333
to
2eabbac
Compare
v2 has these changes at #2742. up to you which one you want to use in Terraform since both are supported. |
This functionality has been released in v0.100.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR updates the Hyperdrive API model to include new forthcoming fields. Some downstream changes in https://github.com/cloudflare/terraform-provider-cloudflare will depend on these changes.
Has your change been tested?
Tests have been updated to account for the new fields.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.