Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams / Gateway: Add TeamsCertificate service #2754

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

alyssamw
Copy link
Contributor

Description

Adds TeamsCertificate resource and service to generate, activate, and delete certificates. Also renames TeamsCertificate in TeamsAccountConfiguration to TeamsCertificateSetting to avoid mixup -- this is a breaking change.

Has your change been tested?

Unit tests added in teams_certificate_test.go.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@alyssamw alyssamw requested a review from jacobbednarz as a code owner July 17, 2024 17:39
Copy link
Contributor

github-actions bot commented Jul 17, 2024

changelog detected ✅

@alyssamw alyssamw force-pushed the master branch 2 times, most recently from f88bbe9 to 01f0034 Compare July 17, 2024 18:20
@jacobbednarz jacobbednarz merged commit 84516fd into cloudflare:master Jul 17, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.100.0 milestone Jul 17, 2024
Copy link
Contributor

This functionality has been released in v0.100.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants