Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tunnel_protocol field to policy #2778

Merged

Conversation

jlu-cloudflare
Copy link
Contributor

Description

Adds a new tunnel_protocol field to the policy, which ultimately allows admins to switch tunnel protocols through their policy settings.

Has your change been tested?

Because it is just adding a new field to the various device settings policy structs, this should not affect existing uses of it. An existing test for the device policy fields has been updated to include the tunnel_protocol field to verify it's use.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Jul 23, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

lgtm once we have this in the API schemas 👍

@jlu-cloudflare jlu-cloudflare force-pushed the jlu/add-tunnel-protocol branch from 4554ed3 to a973e76 Compare July 24, 2024 14:37
@jacobbednarz jacobbednarz merged commit af8922e into cloudflare:master Jul 25, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.101.0 milestone Jul 25, 2024
@jacobbednarz
Copy link
Member

saw this just landed. v2 has these changes at #2784.

Copy link
Contributor

This functionality has been released in v0.101.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants