Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding semgrep.yml for Secrets scanning and more #3221

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

hrushikeshdeshpande
Copy link
Contributor

@hrushikeshdeshpande hrushikeshdeshpande commented Sep 20, 2024

Description

Adding Semgrep.yml file as part of App&ProdSec team's initiative to onboard Semgrep for Secrets scanning and more.

Has your change been tested?

Tested on multiple of our repos.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the code style of this project.

@jacobbednarz
Copy link
Member

@hrushikeshdeshpande are you able to have a look and integrate this with our existing semgrep setup? i don't think it makes sense to have duplicated builds for the same tool if we can avoid it.

@hrushikeshdeshpande
Copy link
Contributor Author

The existing semgrep files we have are for rules and ignoring patterns. I'm afraid I can't integrate CI workflows to any of those (to the best of my knowledge) :/

@jacobbednarz jacobbednarz merged commit 7f3e197 into master Sep 25, 2024
10 of 11 checks passed
@jacobbednarz jacobbednarz deleted the hrushikeshdeshpande-adding-semgrep-yml branch September 25, 2024 02:34
@jacobbednarz
Copy link
Member

let's merge this for now and we can have a look at a follow up to consolidate where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants