AUTH-6588 Replace Access app SelfHostedDomains with Destinations #3667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Access team is deprecating the
self_hosted_domains
field for apps in favor of a newdestinations
field to give us more flexibility in defining different types of domains. This PR adds the new field and removes the old one. I hate to do a breaking change, but it's pretty much always incorrect to send both fields if you mean to change just one, so I think that the toil is worth avoiding the footgun.Also adds the
domain_type
field. Now that they can be either private or public, we needed a way to indicate the type of the "primary" domain.Has your change been tested?
Tests pass! And I used the library to manually create/read/update apps.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.