Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(teams_rules): support internal dns settings #3779

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebassimoes
Copy link

Description

This PR adds support to creating and updating DNS resolver rules configured to forward DNS queries to the internal DNS service with the given internal DNS view identifier.

Has your change been tested?

Automated tests were added to exercise the new code.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

changelog detected ✅

@sebassimoes sebassimoes marked this pull request as draft January 3, 2025 15:38
@sebassimoes sebassimoes force-pushed the sebastiao/support-gateway-internal-dns-settings branch from 205fa27 to 30fb793 Compare January 3, 2025 15:46
With this commit, it's possible to create DNS resolver rules configured
to forward DNS queries to the internal DNS service with the given
internal DNS view identifier.
@sebassimoes sebassimoes force-pushed the sebastiao/support-gateway-internal-dns-settings branch from 30fb793 to 6fd91e2 Compare January 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant