Propagate spans from daphne-server all the way to durable objects #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
armfazh,
bhalleycf,
cjpatton,
fisherdarling and
cbranch
as code owners
mendess
requested review from
lbaquerofierro,
Noah-Kennedy and
RageKnify
as code owners
|
Blocked on open-telemetry/opentelemetry-rust#1882 being released |
mendess
force-pushed
the
mendess/propagate-spans
branch
from
24327d6 to
4b62bc8
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
from
4b62bc8 to
431f90e
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
from
431f90e to
2164093
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
4 times, most recently
from
34c465c to
a67c919
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
5 times, most recently
from
7d7f9e9 to
571a978
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
from
571a978 to
11911b9
Compare
When running workers locally, durable object share the same address space with the main worker, which means they use the same set of global variables. This means that initializing tracing inside test state cleaner can cause the worker to crash due to the double initialization of some components.
mendess
force-pushed
the
mendess/cleanup-deps
branch
from
4de4c38 to
0784a6a
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
from
11911b9 to
6f4ecf6
Compare
mendess
force-pushed
the
mendess/propagate-spans
branch
from
6f4ecf6 to
7e70715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.