Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EndTag and EndTagError as they are public API for on_end_tag #107

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

mitsuhiko
Copy link
Contributor

PR #97 introduced a new callback called on_end_tag which lets one add a callback to be executed when a tag is closed. This callback is invoked with EndTag and returns a result with EndTagError. As both those types are internal it's not entirely possible to use this API except for relying on type inference.

This adds those types to the public API.

@mitsuhiko mitsuhiko requested a review from a team as a code owner November 28, 2021 20:31
@jyn514 jyn514 merged commit 0b5f515 into cloudflare:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants