feat: add ClusterOriginIssuer #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbroglie
approved these changes
Jun 3, 2024
terinjokes
force-pushed
the
terin/clusteroriginissuer
branch
2 times, most recently
from
88c2d05 to
e82f5dd
Compare
heckler1
approved these changes
Jun 4, 2024
terinjokes
force-pushed
the
terin/clusteroriginissuer
branch
2 times, most recently
from
09592e1 to
d8c1b77
Compare
When using this controller in single-tenant clusters it becomes desirable for many users to have a single cluster-scoped issuer rather than each namespace duplicating the issuers and secrets. This changeset introduces a "cluster resource namespace", which defaults to the same namespace as the controller (eg, "origin-ca-issuer"). A ClusterOriginIssuer resource type has been added which resolves SecretKeySelectors in this namespace. Other than determing what namespace to resolve the secret, the implementation is the same as the existing OriginIssuer. Fixes: #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this controller in single-tenant clusters it becomes desirable for many users to have a single cluster-scoped issuer rather than each namespace duplicating the issuers and secrets.
This changeset introduces a "cluster resource namespace", which defaults to the same namespace as the controller (eg, "origin-ca-issuer"). A ClusterOriginIssuer resource type has been added which resolves SecretKeySelectors in this namespace. Other than determing what namespace to resolve the secret, the implementation is the same as the existing OriginIssuer.
Fixes: #24