remove workerd/io as a dependency from pyodide #2811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/move-pyodide
branch
from
c3df0c0 to
c7b7248
Compare
jasnell
approved these changes
Sep 26, 2024
mikea
approved these changes
Sep 26, 2024
fhanau
reviewed
Sep 26, 2024
| @@ -79,6 +79,7 @@ wd_cc_library( | |||
| "//src/pyodide", | |||
| "//src/pyodide:pyodide_extra_capnp", | |||
| "//src/workerd/api/node", | |||
| "//src/workerd/api/pyodide", | |||
There was a problem hiding this comment.
This wasn't listed here so far. I was wondering why the build was working so far despite that – turns out that we were failing to exclude pyodide/pyodide.h from hdrs so far. With the pyodide folder now being a subpackage based on adding a BUILD.bazel file there, the file won't be captured by the glob so this is no longer an issue.
fhanau
approved these changes
Sep 26, 2024
anonrig
force-pushed
the
yagiz/move-pyodide
branch
from
c7b7248 to
a49163a
Compare
|
Any reason not to progress this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes workerd/io as a dependency from pyodide header file and creates a BUILD.bazel inside pyodide folder to simplify things.