Use builtin implementation for isArray and isDeepStrictEqual

cloudflare · Feb 3, 2025 · 82c6dd8 · 82c6dd8
1 parent 59c7c8e
commit 82c6dd8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/.changeset/lazy-windows-provide.md b/.changeset/lazy-windows-provide.md
@@ -0,0 +1,5 @@
+---
+"@cloudflare/unenv-preset": patch
+---
+
+Use builtin implementation for isArray and isDeepStrictEqual
diff --git a/packages/unenv-preset/src/runtime/node/util/index.ts b/packages/unenv-preset/src/runtime/node/util/index.ts
@@ -4,11 +4,9 @@ import {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -30,11 +28,9 @@ export {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -71,6 +67,8 @@ export const {
 	getCallSite,
 	inherits,
 	inspect,
+	isArray,
+	isDeepStrictEqual,
 	log,
 	parseArgs,
 	promisify,
@@ -91,11 +89,9 @@ export default {
 	_exceptionWithHostPort,
 	getSystemErrorMap,
 	getSystemErrorName,
-	isArray,
 	isBoolean,
 	isBuffer,
 	isDate,
-	isDeepStrictEqual,
 	isError,
 	isFunction,
 	isNull,
@@ -113,10 +109,6 @@ export default {
 	/**
 	 * manually unroll workerd-polyfilled-symbols to make it tree-shakeable
 	 */
-	MIMEParams,
-	MIMEType,
-	TextDecoder,
-	TextEncoder,
 	_extend,
 	aborted,
 	callbackify,
@@ -128,10 +120,16 @@ export default {
 	getCallSite,
 	inherits,
 	inspect,
+	isArray,
+	isDeepStrictEqual,
 	log,
+	MIMEParams,
+	MIMEType,
 	parseArgs,
 	promisify,
 	stripVTControlCharacters,
+	TextDecoder,
+	TextEncoder,
 	toUSVString,
 	transferableAbortController,
 	transferableAbortSignal,

diff --git a/packages/unenv-preset/tests/worker/index.ts b/packages/unenv-preset/tests/worker/index.ts
@@ -109,9 +109,12 @@ async function testNodeCompatModules() {
 }
 
 async function testUtilImplements() {
-	const { types } = await import("node:util");
+	const util = await import("node:util");
+	const { types } = util;
 	assert.strictEqual(types.isExternal("hello world"), false);
 	assert.strictEqual(types.isAnyArrayBuffer(new ArrayBuffer(0)), true);
+	assert.strictEqual(util.isArray([]), true);
+	assert.strictEqual(util.isDeepStrictEqual(0, 0), true);
 }
 
 async function testPath() {