Refactor pipelines commands into separate files, rename some options #7769
+947
−497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33c4b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cmackenzie1
force-pushed
the
cole/pipe-160-pipelines-cors
branch
from
c9e676d to
e7987d4
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-wrangler-7769You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7769/npm-package-wrangler-7769Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-wrangler-7769 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-workers-bindings-extension-7769 -O ./cloudflare-workers-bindings-extension.0.0.0-vcdcb204c4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vcdcb204c4.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-create-cloudflare-7769 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-kv-asset-handler-7769miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-miniflare-7769@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-pages-shared-7769@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-unenv-preset-7769@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-vite-plugin-7769@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-vitest-pool-workers-7769@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-workers-editor-shared-7769@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-workers-shared-7769@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957594700/npm-package-cloudflare-workflows-shared-7769Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
cmackenzie1
force-pushed
the
cole/pipe-160-pipelines-cors
branch
from
8661d52 to
133c4d2
Compare
maheshwarip
approved these changes
Jan 22, 2025
cmackenzie1
force-pushed
the
cole/pipe-160-pipelines-cors
branch
2 times, most recently
from
4b31581 to
773ebc2
Compare
**Pipelines is currently in closed beta, renaming these without providing aliases _should_ have no impact** Moving each of the subcommand handlers and options for each subcommand into its own file. This also renames many of the parameters to be more specific. The following parameters have been renamed: | Previous Name | New Name | | ---- | ---- | | access-key-id | r2-access-key-id | | secret-access-key | r2-secret-access-key | | transform | transform-worker | | r2 | r2-bucket | | prefix | r2-prefix | | binding | enable-worker-binding | | http | enable-http | | authentication | require-http-auth | | filename | file-template | | filepath | partition-template | Adds the following new option for `create` and `update` commands: ``` --cors-origins CORS origin allowlist for HTTP endpoint (use * for any origin) [array] ``` Closes https://jira.cfdata.org/browse/PIPE-160.
This also replaces the use of retryOnError with a for-loop as retryOnError wasn't working as expected.
Previously this was nested under the `enableHttp` block which doesn't make sense if HTTP is already enabled and the user just wants to update the authentication or CORS settings.
cmackenzie1
force-pushed
the
cole/pipe-160-pipelines-cors
branch
from
d10d5c9 to
33c4b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipelines is currently in closed beta, renaming these without providing aliases should have limited to zero impact
Moving each of the subcommand handlers and options for each subcommand into its own file. This also renames many of the parameters to be more specific.
The following parameters have been renamed:
Adds the following new option for
createandupdatecommands:Closes https://jira.cfdata.org/browse/PIPE-160.