Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sanitised error messages to wrangler telemetry collection #7856

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Jan 21, 2025

Fixes DEVX-1529


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: shouldn't affect e2e paths
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: documentation included in PR (see telemetry.md changes)

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 52cc2bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-wrangler-7856

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7856/npm-package-wrangler-7856

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-wrangler-7856 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-workers-bindings-extension-7856 -O ./cloudflare-workers-bindings-extension.0.0.0-v74b39851d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v74b39851d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-create-cloudflare-7856 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-kv-asset-handler-7856

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-miniflare-7856

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-pages-shared-7856

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-unenv-preset-7856

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-vite-plugin-7856

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-vitest-pool-workers-7856

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-workers-editor-shared-7856

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-workers-shared-7856

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12996849845/npm-package-cloudflare-workflows-shared-7856

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/errors.ts Outdated Show resolved Hide resolved
packages/wrangler/src/errors.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love the telemetryMessage option

packages/wrangler/src/errors.ts Outdated Show resolved Hide resolved
packages/wrangler/src/errors.ts Outdated Show resolved Hide resolved
packages/wrangler/src/errors.ts Show resolved Hide resolved
@emily-shen emily-shen marked this pull request as ready for review January 23, 2025 21:46
@emily-shen emily-shen requested review from a team as code owners January 23, 2025 21:46
@emily-shen emily-shen force-pushed the emily/telemetry-sanitise-error-msgs branch from 3502776 to b2a88e1 Compare January 27, 2025 19:29
@emily-shen emily-shen merged commit 2b6f149 into main Jan 27, 2025
33 checks passed
@emily-shen emily-shen deleted the emily/telemetry-sanitise-error-msgs branch January 27, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants