Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R2 bucket name validation error #7904

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jan 24, 2025

Fixes CUSTESC-48328

Fixes validation for R2 bucket names, the regex was wrongly rejecting buckets starting with a number and the message wasn't as clear as it could be on what was going wrong.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixing validation

@WalshyDev WalshyDev requested a review from a team as a code owner January 24, 2025 23:32
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 5bd5d45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-wrangler-7904

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7904/npm-package-wrangler-7904

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-wrangler-7904 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-bindings-extension-7904 -O ./cloudflare-workers-bindings-extension.0.0.0-v7ffc8dad3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7ffc8dad3.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-create-cloudflare-7904 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-kv-asset-handler-7904

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-miniflare-7904

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-pages-shared-7904

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-unenv-preset-7904

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-vite-plugin-7904

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-vitest-pool-workers-7904

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-editor-shared-7904

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-shared-7904

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workflows-shared-7904

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/fix-r2-bucket-name-validation branch from b50f2c1 to 88c4d39 Compare January 24, 2025 23:54
@WalshyDev WalshyDev force-pushed the walshy/fix-r2-bucket-name-validation branch from 88c4d39 to 5bd5d45 Compare January 25, 2025 00:09
@penalosa penalosa merged commit 50b13f6 into main Jan 27, 2025
33 checks passed
@penalosa penalosa deleted the walshy/fix-r2-bucket-name-validation branch January 27, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants