-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix R2 bucket name validation error #7904
Conversation
🦋 Changeset detectedLatest commit: 5bd5d45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-wrangler-7904 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7904/npm-package-wrangler-7904 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-wrangler-7904 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-bindings-extension-7904 -O ./cloudflare-workers-bindings-extension.0.0.0-v7ffc8dad3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7ffc8dad3.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-create-cloudflare-7904 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-kv-asset-handler-7904 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-miniflare-7904 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-pages-shared-7904 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-unenv-preset-7904 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-vite-plugin-7904 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-vitest-pool-workers-7904 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-editor-shared-7904 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workers-shared-7904 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12959725913/npm-package-cloudflare-workflows-shared-7904 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
b50f2c1
to
88c4d39
Compare
88c4d39
to
5bd5d45
Compare
Fixes CUSTESC-48328
Fixes validation for R2 bucket names, the regex was wrongly rejecting buckets starting with a number and the message wasn't as clear as it could be on what was going wrong.