-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(wrangler): runWranglerDev always log error #7907
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-wrangler-7907 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7907/npm-package-wrangler-7907 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-wrangler-7907 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-workers-bindings-extension-7907 -O ./cloudflare-workers-bindings-extension.0.0.0-v9e42ba914.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v9e42ba914.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-create-cloudflare-7907 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-kv-asset-handler-7907 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-miniflare-7907 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-pages-shared-7907 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-unenv-preset-7907 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-vite-plugin-7907 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-vitest-pool-workers-7907 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-workers-editor-shared-7907 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-workers-shared-7907 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12963461044/npm-package-cloudflare-workflows-shared-7907 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
I am not convinced this is the right thing to do. When the tests are passing we do not want to see all these logs. I'd prefer to look into how we could capture the logs in CI for tests that fail without constantly spamming the output. |
Rather worryingly, the fixtures that depend upon this e.g. additional-modules got a cache hit, which means that Turbo didn't realise that they had a dependency on |
This would only display errors though. Yes the problem is mostly CI as it used different platforms which make it impossible to test locally - in my case the error was reproducible locally but seeing the error on the CI would have speed up the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so I had a play around and I think that the stderr is pretty minimal when there are no failures. Can you confirm that this would have actually shown you the errors you needed @vicb?
Yes it does - thanks for merging! |
@petebacondarwin this is reverting one change you made a couple weeks ago.
I had CI (and local) that were impossible to debug without this.
I see that you mention that the logs would be printed on timeout anyway... but that's unless your test timeout is less than the timeout in
runLongLivedWrangler
- it is the case with the failures I had (30 vs 50s in updated file).Adding
stderr
only should hopefully not be too spammy?