Use wrangler outputs for wrangler deploy and versions upload #351
+556
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 6, 2025
jrf0110
reviewed
Feb 6, 2025
| setOutput("deployment-alias-url", aliasUrl); | ||
| setOutput("pages-deployment-alias-url", aliasUrl); | ||
| } | ||
| switch (true) { |
There was a problem hiding this comment.
Look I kinda like it; But it's kinda clever. It took me a little too long to parse exactly and make sure you were doing what you wanted to do. It would be much more clear with simple if statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #343 and #311.
Uses wrangler outputs for wrangler deploy and versions upload so that we can accurately set
deployment-urlforwrangler deployandversions upload