Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) Bump Google Java Formatter to 1.22.0 #3102

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Jul 24, 2024

With the update to JDK21 the Google Java Formatter was throwing following exception

100 3309k  100 3309k    0     0  4753k      0 --:--:-- --:--:-- --:--:-- 77.7M
./src/scheduler/src/test/java/org/cloudfoundry/autoscaler/scheduler/rest/ScheduleRestControllerCreateScheduleAndNofifyScalingEngineTest.java: error: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'
java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'
	at com.google.googlejavaformat.java.RemoveUnusedImports.getSimpleName(RemoveUnusedImports.java:263)
	at com.google.googlejavaformat.java.RemoveUnusedImports.buildReplacements(RemoveUnusedImports.java:245)
	at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports(RemoveUnusedImports.java:197)
	at com.google.googlejavaformat.java.FormatFileCallable.fixImports(FormatFileCallable.java:55)
	at com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:46)
	at com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:26)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:[15](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/10076579459/job/27857239602?pr=3099#step:4:16)83)
./src/scheduler/src/test/java/org/cloudfoundry/autoscaler/scheduler/rest/ScheduleSyncRestControllerTest.java: error: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'
java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'
	at com.google.googlejavaformat.java.RemoveUnusedImports.getSimpleName(RemoveUnusedImports.java:263)

Reason:

Failing Build

Fix

Bump Google java format to the latest version i.e 1.22.0

@asalan316 asalan316 force-pushed the bump-google-java-formatter branch from aa5e539 to 1473552 Compare July 24, 2024 14:10
@asalan316 asalan316 changed the title bump google java format to 1.22.0 chore(deps) Bump Google Java Formatter to 1.22.0 Jul 24, 2024
@asalan316 asalan316 marked this pull request as ready for review July 24, 2024 14:14
@asalan316 asalan316 added the dependencies Pull requests that update a dependency file label Jul 24, 2024
@asalan316 asalan316 force-pushed the bump-google-java-formatter branch from 1473552 to 84ba9f4 Compare July 24, 2024 14:22
Copy link

@asalan316 asalan316 enabled auto-merge July 24, 2024 14:29
@asalan316 asalan316 merged commit 154839d into main Jul 24, 2024
28 checks passed
@asalan316 asalan316 deleted the bump-google-java-formatter branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants