Disable garden's containerd_mode for bosh lite #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had reports such as cloudfoundry/bpm-release#176 where running bosh lite with the latest runc will fail to deploy or restart. While we haven't been able to find an absolute root cause, it is the case that garden-runc-release switched the default of this property a few months back: cloudfoundry/garden-runc-release#315. Garden has some issues with running itself under bpm (see https://github.com/cloudfoundry/garden-runc-release/blob/develop/docs/BPM_support.md) So we postulate that doing the reverse (running bpm under Garden) has some similar issues. We have not been able to reproduce the issue in cloudfoundry/bpm-release#176 with containerd_mode set to false.
jpalermo
requested review from
a team,
bgandon and
xtreme-nitin-ravindran
and removed request for
a team
rkoster
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had reports such as
cloudfoundry/bpm-release#176 where running bosh lite with the latest runc will fail to deploy or restart. While we haven't been able to find an absolute root cause, it is the case that garden-runc-release switched the default of this property a few months back: cloudfoundry/garden-runc-release#315.
Garden has some issues with running itself under bpm (see https://github.com/cloudfoundry/garden-runc-release/blob/develop/docs/BPM_support.md) So we postulate that doing the reverse (running bpm under Garden) has some similar issues.
We have not been able to reproduce the issue in
cloudfoundry/bpm-release#176 with containerd_mode set to false.