Add medium VM type to cloud-config #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenehret
requested changes
Oct 23, 2024
| @@ -14,6 +14,9 @@ vm_types: | |||
| - name: small-highmem-100GB-ephemeral-disk | |||
| cloud_properties: | |||
| instance_type: small-highmem-100GB-ephemeral-disk | |||
| - name: medium | |||
| cloud_properties: | |||
| instance_type: m1.large | |||
There was a problem hiding this comment.
Maybe we should change the other flavors to the defaults listed on https://docs.openstack.org/nova/latest/admin/flavors.html?
| @@ -26,6 +26,10 @@ vm_types: | |||
| cloud_properties: | |||
| instance_type: ecs.sn2ne.xlarge | |||
| ephemeral_disk: {size: "51_200"} | |||
| - name: medium | |||
| cloud_properties: | |||
| instance_type: ecs.sn1.2xlarge | |||
There was a problem hiding this comment.
I've only found type ecs.sn1ne.2xlarge with 8 CPUs and 16GB memory. Did you mean that size?
Docu: https://www.alibabacloud.com/help/en/ecs/user-guide/compute-optimized-instance-families
There was a problem hiding this comment.
Yes ecs.sn1ne.2xlarge is much bigger, if we compare it with the compiler vm type ecs.sn1.large (4 CPUs and 8GB memory). Also network baseline bandwidth is 2 Gbit/s.
jochenehret
approved these changes
Oct 24, 2024
jochenehret
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
Adds medium VM type to AliCloud, vSphere and OpensStack cloud-config.
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
cloud-config examples in https://github.com/cloudfoundry/cf-deployment/tree/main/iaas-support
Please provide any contextual information.
#1202
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Adds medium VM type to AliCloud, vSphere and OpensStack cloud-config.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!