Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ca_file for http client in curl mode #130

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

strehle
Copy link
Member

@strehle strehle commented Nov 18, 2023

With curl simulation mode the parameters from curl needs to be passed
The parameters from uaac target xxx are not used here.

Therefore, ca cert was missing. -b for --skip-ssl-validation is available

For uaac target --ca-cert there is was no setting.

Added -C or --cacert because these are the parameters from curl

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@strehle strehle linked an issue Nov 18, 2023 that may be closed by this pull request
@strehle strehle requested review from hsinn0 and a team November 18, 2023 16:59
With curl simulation mode the parameters from curl needs to be passed
The parameters from uaac target xxx are not used here.
Therefore, ca cert was missing. -b for --skip-ssl-validation is available
For uaac target --ca-cert there is was no setting.
Added -C or --cacert because these are the parameters from curl
@strehle strehle force-pushed the issue/128/addCaCert branch from a12981b to 5b82609 Compare November 18, 2023 17:12
@strehle strehle added ruby Pull requests that update Ruby code and removed ruby Pull requests that update Ruby code labels Nov 18, 2023
@strehle strehle requested review from beyhan and rkoster November 21, 2023 09:28
@strehle
Copy link
Member Author

strehle commented Nov 21, 2023

@beyhan Added you because this issue causes problems so that I would like to release uaac but also dont want break the cross company rules (about review) so that you and @rkoster should judge, can I merge and release ?

@beyhan
Copy link
Member

beyhan commented Nov 21, 2023

The change looks straight forward to me. Best would be if this could be coordinated in the UAA area itself. My observation is that the cooperation in the UAA area works good.

@strehle
Copy link
Member Author

strehle commented Nov 21, 2023

f. My observation is that the cooperation in the UAA area works good.

Yes sure, the problem is that if there is an escalation then we need to have a new release in a very short time and for this I ask for your approval.

The cross company reviews work, so I asked you not because I dont get a review from VMware colleagues, but because of an SAP internal escalation

Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@Tallicia
Copy link
Contributor

Feel free to go ahead and merge this or indicate if it's ok for us to merge.

@strehle strehle merged commit 5139b8d into main Nov 21, 2023
5 checks passed
@strehle strehle deleted the issue/128/addCaCert branch November 21, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

CA cert is not used by uaac curl
5 participants