-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ca_file for http client in curl mode #130
Conversation
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
With curl simulation mode the parameters from curl needs to be passed The parameters from uaac target xxx are not used here. Therefore, ca cert was missing. -b for --skip-ssl-validation is available For uaac target --ca-cert there is was no setting. Added -C or --cacert because these are the parameters from curl
a12981b
to
5b82609
Compare
The change looks straight forward to me. Best would be if this could be coordinated in the UAA area itself. My observation is that the cooperation in the UAA area works good. |
Yes sure, the problem is that if there is an escalation then we need to have a new release in a very short time and for this I ask for your approval. The cross company reviews work, so I asked you not because I dont get a review from VMware colleagues, but because of an SAP internal escalation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Feel free to go ahead and merge this or indicate if it's ok for us to merge. |
With curl simulation mode the parameters from curl needs to be passed
The parameters from uaac target xxx are not used here.
Therefore, ca cert was missing. -b for --skip-ssl-validation is available
For uaac target --ca-cert there is was no setting.
Added -C or --cacert because these are the parameters from curl