Introduce timeout safeguard for migration sql queries #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
reviewed
Feb 9, 2024
FloThinksPi
force-pushed
the
document-migration-issues
branch
2 times, most recently
from
4b04796 to
0a217c2
Compare
FloThinksPi
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 21, 2024
This change enables operators to configure the new config property `max_migration_statement_runtime_in_seconds` see cloudfoundry/cloud_controller_ng#3633.
3 tasks
FloThinksPi
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 21, 2024
This change enables operators to configure the new config property `max_migration_statement_runtime_in_seconds` see cloudfoundry/cloud_controller_ng#3633.
FloThinksPi
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 21, 2024
This change enables operators to configure the new config property `max_migration_statement_runtime_in_seconds` see cloudfoundry/cloud_controller_ng#3633.
FloThinksPi
force-pushed
the
document-migration-issues
branch
from
6df6989 to
b7a9b57
Compare
FloThinksPi
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 28, 2024
This change enables operators to configure the new config property `max_migration_statement_runtime_in_seconds` see cloudfoundry/cloud_controller_ng#3633.
philippthun
approved these changes
Mar 12, 2024
philippthun
reviewed
Mar 12, 2024
The mysql statement timeout just works for selects. Additionally mysql does not support transactional rollbacks of DDL statements. Thus there is a risk to exit in an unclean state which might cause CC runtime errors and addtionally the timeout on selects only is not worth much functionally. Add max_migration_statement_runtime_in_seconds into default config For consitency since other optional parameters are also defined there explicitly.
philippthun
force-pushed
the
document-migration-issues
branch
from
d601835 to
84fcd44
Compare
philippthun
pushed a commit
to cloudfoundry/capi-release
that referenced
this pull request
Apr 9, 2024
This change enables operators to configure the new config property `max_migration_statement_runtime_in_seconds` see cloudfoundry/cloud_controller_ng#3633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests