Use DISTINCT only when required (service plan|offering list fetcher) #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of PR cloudfoundry#3620 [1] it has been validated that there is no overlap between the different sources (UNIONed datasets). But as these single datasets are created by JOINing several tables, there might be duplicates depending on the cardinality of those relations. Thus the overall DISTINCT is replaced by DISTINCTs added when JOINing a table with a one-to-many relation. Calling '.distinct' multiple times does not have any negative effect as this simply sets a flag on the Sequel dataset. This change should improve performance of requests to the following endpoints whenever those JOINs are not needed (e.g. depending on request parameters): - /v3/service_offerings - /v3/service_plans Tests now ensure that there are: - multiple plans per offering - multiple service instances per plan - multiple visibilities per plan - multiple spaces per organization [1] cloudfoundry#3620
philippthun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of PR #3620 it has been validated that there is no overlap between the different sources (
UNIONed datasets). But as these single datasets are created byJOINing several tables, there might be duplicates depending on the cardinality of those relations. Thus the overallDISTINCTis replaced byDISTINCTs added whenJOINing a table with a one-to-many relation. Calling.distinctmultiple times does not have any negative effect as this simply sets a flag on the Sequel dataset.This change should improve performance of requests to the following endpoints whenever those
JOINs are not needed (e.g. depending on request parameters):Tests now ensure that there are:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests