Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 #4070

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Ruby 3.3 #4070

wants to merge 3 commits into from

Conversation

sethboyles
Copy link
Member

#3559

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

* this gem is blocking us from upgrading to Ruby 3.3, but it seems we don't actually use it
* the RFC gem doesn't support ruby 3.3, but we don't seem to use it anyway
@Samze
Copy link
Contributor

Samze commented Nov 5, 2024

I wonder if we should pre-emptively run https://github.com/cloudfoundry/cf-performance-tests against this change to see if theres any noticeable positive/negative effect.

@sethboyles
Copy link
Member Author

Wouldn't hurt, I suppose. If we are starting to care about pre-release data, maybe we should have cf-performance-tests that run on prereleases, not just after capi is bumped in cf-deployment?

That said, I think most of our issues are due to DB queries, so I would be surprised if this makes a significant impact. If Ruby code turns out to have a big impact maybe we should push the BOSH team get Rust in the bosh ruby package so we can turn on YJIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants