Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt custom cops to v1 #4165

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Jan 7, 2025

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun changed the title Adapt custom cops to v1 Adapt custom cops to v1, enable new cops and autocorrect offenses Jan 9, 2025
@moleske
Copy link
Member

moleske commented Jan 12, 2025

oh whoops didn't see this when I made #4169

Feel free to close my pr if this one is good to go. Or cherry pick off of my branch if it is worth it. I attempted to bump to custom cops to v1 but got lazy, so good to see that here!

@philippthun philippthun changed the title Adapt custom cops to v1, enable new cops and autocorrect offenses Adapt custom cops to v1 Jan 14, 2025
@philippthun philippthun marked this pull request as ready for review January 14, 2025 09:47
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@philippthun philippthun merged commit 1dac91f into cloudfoundry:main Jan 16, 2025
8 checks passed
@philippthun philippthun deleted the rubocop branch January 16, 2025 09:52
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jan 16, 2025
Changes in cloud_controller_ng:

- Adapt custom cops to v1
    PR: cloudfoundry/cloud_controller_ng#4165
    Author: Philipp Thun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants