Remove foreign key contraint in table job_warnings on 'fk_jobs_id' #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job_warnings table was created in a wrong way. There are two columns 'job_id' and 'fk_jobs_id'. There is a foreign key constraint on 'fk_jobs_id', which references jobs(id). CC coding never inserts data into 'fk_jobs_id', but only into 'job_id'. So the foreign key constraint is not needed and causes way slower cleanup of pollable jobs, which can even run into DB statement timeouts and cause an ever growing table.
svkrieger
force-pushed
the
remove-foreign-key-contraint-from-job-warnings
branch
from
2cf1a79 to
ec7b7f9
Compare
philippthun
approved these changes
Jan 17, 2025
Unfortunately this is only partially true. See #4175. |
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jan 19, 2025
Changes in cloud_controller_ng:
- Remove foreign key contraint in table job_warnings on 'fk_jobs_id'
PR: cloudfoundry/cloud_controller_ng#4174
Author: Sven Krieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion of foreign key constraint in
job_warningstable onfk_jobs_id. This also deletes the columnfk_jobs_id.This will drastically increase the speed of the cleanup job of the pollable jobs table.
The job_warnings table was created in a wrong way. There are two columns 'job_id' and 'fk_jobs_id'. There is a foreign key constraint on 'fk_jobs_id', which references jobs(id). CC coding never inserts data into 'fk_jobs_id', but only into 'job_id'. So the foreign key constraint is not needed but causes way slower cleanup of pollable jobs, which can even run into DB statement timeouts and cause an ever growing table. CC already takes care of deleting job_warnings when jobs are deleted.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests